Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: categorization on tech stack page #1265

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Conversation

ujwal-yadav
Copy link
Contributor

@ujwal-yadav ujwal-yadav commented Oct 1, 2023

Description

This Pull Request addresses the issue related to the Tech Stack page's need for improved categorization. It introduces a categorization feature to enhance the organization and navigation of various technologies on the Tech Stack page.
In anticipation of future growth and expansion of the technology stack, this Pull Request has also been designed with scalability in mind, so that it can easily add additional categories to accommodate new technologies and tools without altering the existing code logic.

Fixes #375

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been tested with all screen sizes on browsers like- Chrome, Firefox, Brave, and Edge.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Screenshots or example output

tech-stack-page

@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 4e2a88f
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/652ce060b66d9c000869cb51
😎 Deploy Preview https://deploy-preview-1265--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 1, 2023

@ujwal-yadav is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@priyankarpal priyankarpal changed the title feat(common): add categorization on tech stack page style: categorization on tech stack page Oct 7, 2023
@joshi-kaushal
Copy link
Member

Hi, this is actually great, loved it. But I have a suggestion, Can we do something like this for desktop screen sizes?

Toggle to see photo

For mobile, i think the same design with two items on each row, center-aligned would look great.

Let me know what you both think @ujwal-yadav @priyankarpal

@ujwal-yadav
Copy link
Contributor Author

ujwal-yadav commented Oct 8, 2023

Hi, this is actually great, loved it. But I have a suggestion, Can we do something like this for desktop screen sizes?

Toggle to see photo

For mobile, i think the same design with two items on each row, center-aligned would look great.

Let me know what you both think @ujwal-yadav @priyankarpal

Hello @joshi-kaushal, As the width of the container is only 1280px, so in future when no. of tech stack will increase then it will make the frame works column look congested as there will be very less space available for it.
Still I can implement your suggestions if you want to. So, let me know your thoughts.

@joshi-kaushal
Copy link
Member

joshi-kaushal commented Oct 8, 2023 via email

@ujwal-yadav ujwal-yadav closed this Oct 8, 2023
@ujwal-yadav ujwal-yadav reopened this Oct 8, 2023
@ujwal-yadav
Copy link
Contributor Author

ujwal-yadav commented Oct 8, 2023

  1. Limit to a certain number (say 6) and add a Load more or Show all button 2. Horizontal scrolling 3. Tabs (like pagination). Would add more clarifying to this point if you need. This is just what I could think of right now. Maybe there's something even better.

Or we can reduce the size of the frameworks icon card by few px.

@joshi-kaushal
Copy link
Member

@ujwal-yadav yes that's a good idea as well. Can surely try that

@priyankarpal priyankarpal added the 💬 talk: discussion Open for discussions and feedback label Oct 8, 2023
@ujwal-yadav
Copy link
Contributor Author

@joshi-kaushal @priyankarpal I have implemented the UI changes. You can review it.

@atapas
Copy link
Member

atapas commented Oct 11, 2023

@joshi-kaushal please finish the review and let me know when it is ready for merge.

@joshi-kaushal
Copy link
Member

@ujwal-yadav can you please share screenshots for both mobile and laptop screen sizes?

@ujwal-yadav
Copy link
Contributor Author

@ujwal-yadav can you please share screenshots for both mobile and laptop screen sizes?

Laptop screen
Screenshot  (225)

Mobile screen
localhost_3000_tech-stacks(iPhone XR)

@atapas
Copy link
Member

atapas commented Oct 13, 2023

@priyankarpal
Copy link
Member

python? @atapas

@atapas
Copy link
Member

atapas commented Oct 13, 2023

python? @atapas

I don't think we use it. Let's remove it.

@ujwal-yadav
Copy link
Contributor Author

python? @atapas

I don't think we use it. Let's remove it.

I have removed Python. It can be reviewed now.

@priyankarpal priyankarpal added ready to merge and removed 💬 talk: discussion Open for discussions and feedback waiting for reviewers labels Oct 13, 2023
Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@atapas atapas merged commit ebb7824 into reactplay:main Oct 16, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Tech stack page needs better categorization
4 participants