-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding stop watch application for hackoctcober fest #1278
Conversation
❌ Deploy Preview for reactplayio failed.
|
@irfanmit is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
Hi @irfanmit thanks for your contribution! Can you please mention which issue does it solve? |
Hi, @joshi-kaushal i have added a new play feature....as a beginner in open source....this is a simple application of stopwatch....regarding the issue....i am not into any issues (from the issues list).....but will be happy to contributing many more for this repo in future This is a test app to check how merging is done to some real time repo....if anything you wanna change please gladly ask i will be happy to do so.....regards |
Congratulations on completing your first open-source contribution @irfanmit! We follow a protocol to keep everything streamlined. One of which is very pull request must be assigned to an issue.
|
Hello @joshi-kaushal sir...like you said i followed the proper guide and on the issue no #1311(stopwatch app) i did not get any reply for further instruction would you please look into it sir....will be grateful |
@irfanmit Thanks. You can also mention the issue no. in |
Sir thank you so much....for helping me as a beginner I have mentioned the issue in the PR description in the fixes...much appreciated your help thanks once again |
Don't call me sir haha. Kaushal is fine. Don't forget to help others whey they need. |
Hi sir @priyankarpal ...is there any update.......there are some unresolved conversation i had replied days ago but that are pending still |
Kicked off the build for testing... |
when I try to search the project to the preview build it's showing me not found |
is it something related with my code? How can i solve this |
search from here https://deploy-preview-1278--reactplayio.netlify.app/ |
Hi, @priyankarpal sir....i saw the issue...unexpectedly export code was missing from index.js But there is some issue while pushing back the code to my branch SHOULD I RAISE THIS ISSUE IN |
you can create a new fresh PR |
Description
Hi, i am adding a simple stopwatch application on this repo...this is a simple react application
will be contributing more this is a check project if i am able to merge or not
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
As for the change the new feature app has a simple stopwatch application
Fixes # (issue)
Issue no #1311
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have tested on my local machine it works well the code has no bugs or issue
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
I checked the code by manual verification i ran it on my pc and it works well
Checklist:
Screenshots or example output