Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stop watch application for hackoctcober fest #1278

Closed
wants to merge 14 commits into from
Closed

Adding stop watch application for hackoctcober fest #1278

wants to merge 14 commits into from

Conversation

irfanmit
Copy link

@irfanmit irfanmit commented Oct 3, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Hi, i am adding a simple stopwatch application on this repo...this is a simple react application
will be contributing more this is a check project if i am able to merge or not

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
As for the change the new feature app has a simple stopwatch application

Fixes # (issue)
Issue no #1311

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have tested on my local machine it works well the code has no bugs or issue

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
I checked the code by manual verification i ran it on my pc and it works well

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

WhatsApp Image 2023-10-03 at 4 45 37 PM

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit f70975c
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65411179f57d2c0008958310

@vercel
Copy link

vercel bot commented Oct 3, 2023

@irfanmit is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@irfanmit irfanmit changed the title Faisal play Adding stop watch application for hackoctcober fest Oct 3, 2023
src/plays/Faisalplay/cover.png Outdated Show resolved Hide resolved
@joshi-kaushal
Copy link
Member

Hi @irfanmit thanks for your contribution! Can you please mention which issue does it solve?

@irfanmit
Copy link
Author

irfanmit commented Oct 6, 2023

Hi @irfanmit thanks for your contribution! Can you please mention which issue does it solve?

Hi, @joshi-kaushal i have added a new play feature....as a beginner in open source....this is a simple application of stopwatch....regarding the issue....i am not into any issues (from the issues list).....but will be happy to contributing many more for this repo in future

This is a test app to check how merging is done to some real time repo....if anything you wanna change please gladly ask i will be happy to do so.....regards
Thanks

@joshi-kaushal
Copy link
Member

Congratulations on completing your first open-source contribution @irfanmit!

We follow a protocol to keep everything streamlined. One of which is very pull request must be assigned to an issue.
It's okay, we can still fix this.

  1. From the Issues tab on ReactPlay GitHub codebase, click on New Issue and then New Play. (Or simply click here)
  2. Fill in everything mentioned, and ask to assign it to yourself.
  3. Click Submit new issue.
  4. If nobody replies within 24hrs, ping me here again or on our discord server. I will assign it to you.

@priyankarpal priyankarpal added the no issue number no issue number, we can't merge the PR label Oct 7, 2023
@irfanmit
Copy link
Author

irfanmit commented Oct 8, 2023

Congratulations on completing your first open-source contribution @irfanmit!

We follow a protocol to keep everything streamlined. One of which is very pull request must be assigned to an issue. It's okay, we can still fix this.

  1. From the Issues tab on ReactPlay GitHub codebase, click on New Issue and then New Play. (Or simply click here)
  2. Fill in everything mentioned, and ask to assign it to yourself.
  3. Click Submit new issue.
  4. If nobody replies within 24hrs, ping me here again or on our discord server. I will assign it to you.

Hello @joshi-kaushal sir...like you said i followed the proper guide and on the issue no #1311(stopwatch app) i did not get any reply for further instruction would you please look into it sir....will be grateful
Regards sir

@joshi-kaushal
Copy link
Member

@irfanmit Thanks. You can also mention the issue no. in Fixex # (issue) in the PR description. As said earlier, this keeps everything in order and doesn't confuse anyone. We will merge this very soon. Congrats once again! 🎉

joshi-kaushal
joshi-kaushal previously approved these changes Oct 8, 2023
@irfanmit
Copy link
Author

irfanmit commented Oct 8, 2023

@irfanmit Thanks. You can also mention the issue no. in Fixex # (issue) in the PR description. As said earlier, this keeps everything in order and doesn't confuse anyone. We will merge this very soon. Congrats once again! 🎉

Sir thank you so much....for helping me as a beginner I have mentioned the issue in the PR description in the fixes...much appreciated your help thanks once again ☺️

@joshi-kaushal
Copy link
Member

Don't call me sir haha. Kaushal is fine. Don't forget to help others whey they need.

src/plays/Faisalplay/cover.webp Outdated Show resolved Hide resolved
src/plays/Faisalplay/Stopwatch.js Outdated Show resolved Hide resolved
src/plays/Faisalplay/Readme.md Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added changes required need to change some thing and removed no issue number no issue number, we can't merge the PR labels Oct 8, 2023
@irfanmit
Copy link
Author

Hi sir @priyankarpal ...is there any update.......there are some unresolved conversation i had replied days ago but that are pending still

@priyankarpal priyankarpal added ready to merge and removed changes required need to change some thing labels Oct 12, 2023
@atapas
Copy link
Member

atapas commented Oct 12, 2023

Kicked off the build for testing...

@priyankarpal
Copy link
Member

when I try to search the project to the preview build it's showing me not found

@irfanmit irfanmit mentioned this pull request Oct 14, 2023
8 tasks
@irfanmit
Copy link
Author

when I try to search the project to the preview build it's showing me not found

is it something related with my code? How can i solve this

@priyankarpal
Copy link
Member

when I try to search the project to the preview build it's showing me not found

is it something related with my code? How can i solve this

search from here https://deploy-preview-1278--reactplayio.netlify.app/

@irfanmit
Copy link
Author

when I try to search the project to the preview build it's showing me not found

is it something related with my code? How can i solve this

search from here https://deploy-preview-1278--reactplayio.netlify.app/

Hi, @priyankarpal sir....i saw the issue...unexpectedly export code was missing from index.js

i have added it back
Screenshot 2023-10-15 170609

But there is some issue while pushing back the code to my branch
error pushing faisalplay

SHOULD I RAISE THIS ISSUE IN ISSUE SECTION?

@priyankarpal
Copy link
Member

when I try to search the project to the preview build it's showing me not found

is it something related with my code? How can i solve this

search from here https://deploy-preview-1278--reactplayio.netlify.app/

Hi, @priyankarpal sir....i saw the issue...unexpectedly export code was missing from index.js

i have added it back Screenshot 2023-10-15 170609

But there is some issue while pushing back the code to my branch error pushing faisalplay

SHOULD I RAISE THIS ISSUE IN ISSUE SECTION?

you can create a new fresh PR

@priyankarpal priyankarpal linked an issue Oct 16, 2023 that may be closed by this pull request
4 tasks
@irfanmit irfanmit closed this Oct 16, 2023
@irfanmit irfanmit reopened this Oct 16, 2023
@irfanmit irfanmit closed this by deleting the head repository Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Adding a simple stopwatch application #hackoctober #React
5 participants