Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prime sponsor button styling while hovering on it max-width of 800px #1293

Merged
merged 8 commits into from
Oct 11, 2023
Merged

fix: prime sponsor button styling while hovering on it max-width of 800px #1293

merged 8 commits into from
Oct 11, 2023

Conversation

letscodedanish
Copy link
Contributor

@letscodedanish letscodedanish commented Oct 4, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This PR fixes the "Become a Prime sponsor" Button issue. The styling for the "Become a Prime Sponsor" button is not correct.
1 file changed, 3 insertions(+), 4 deletions(-)

Fixes #1268

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested the application after fixing the issue , everything is working fine.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or example output

vs-code-cahnges:-
Screenshot (478)
Screenshot (477)

Changed UI
Screenshot (480)

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit c3128f5
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65254d123479820008774476
😎 Deploy Preview https://deploy-preview-1293--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 4, 2023

@letscodedanish is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@joshi-kaushal
Copy link
Member

Hi @letscodedanish! Thanks for your contribution! Is it mobile-friendly? Can you share a GIF/multiple photos to show how does this look on different screen sizes? Also make sure to update this branch with the main

@letscodedanish
Copy link
Contributor Author

letscodedanish commented Oct 6, 2023

@joshi-kaushal It's working fine with different screen sizes .

Screenshots:-
Screenshot (487)

Screenshot (486)

video:-

bandicam.2023-10-06.10-48-22-434.mp4

@letscodedanish
Copy link
Contributor Author

Please review it @joshi-kaushal .

@letscodedanish
Copy link
Contributor Author

@joshi-kaushal please request a review from someone.

@letscodedanish
Copy link
Contributor Author

@priyankarpal please have a look on it.

@priyankarpal priyankarpal changed the title Fixed become a prime sponsor button styling while hovering on it in max-width of 800px fix: prime sponsor button styling while hovering on it max-width of 800px Oct 11, 2023
@priyankarpal
Copy link
Member

@letscodedanish please check the conventional commits docs https://www.conventionalcommits.org/en/v1.0.0/

@priyankarpal priyankarpal merged commit 7c518a4 into reactplay:main Oct 11, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The styling for the "Become a Prime Sponsor" button is not correct.
3 participants