Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated GitHub star count number format #1321

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

FreemRL
Copy link
Contributor

@FreemRL FreemRL commented Oct 10, 2023

Description

I changed the GitHub star count number format to show numbers in a more efficient way --> e.g. 1.1K, 1.1M etc.

Fixes #1320

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I used the development server to test functionality. yarn start.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Before:

before

After:

after

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 3ffc902
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6526374b7839b00009b04131
😎 Deploy Preview https://deploy-preview-1321--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FreemRL FreemRL changed the title Updated GitHub star number format feat: updated GitHub star number format Oct 10, 2023
@FreemRL FreemRL changed the title feat: updated GitHub star number format feat: updated GitHub star count number format Oct 10, 2023
@atapas
Copy link
Member

atapas commented Oct 10, 2023

https://deploy-preview-1321--reactplayio.netlify.app/

Hey @FreemRL I do not see the change reflecting in the preview build above.

@FreemRL
Copy link
Contributor Author

FreemRL commented Oct 10, 2023

Okay I forgot to change it at DefaultBanner.jsx as well, sorry for that. Does it work now? @atapas

@FreemRL
Copy link
Contributor Author

FreemRL commented Oct 10, 2023

I can't deploy my changes at Netlify:

image

image

I think therefor it can't be shown in the deploy preview. Any idea how I can fix the deploy on Netlify? @atapas
Because it works just fine at the development server

@FreemRL
Copy link
Contributor Author

FreemRL commented Oct 10, 2023

UPDATE:

I found a way to get the initialization done:
image

Now the building part is the next problem:
image

image

This results in the skip of deployment:
image

@Sarhan41
Copy link

Hey , i had checked this issue, where i go to api endpoint on browser, it till says 1093 instead of real count.
so it is issue with the api or there backend. i don't see any issue in the api request or fetchin it , data in the json file of that api is wrong.
Screenshot 2023-10-11 071538
you can go here and check GITHUBAPI.

@FreemRL
Copy link
Contributor Author

FreemRL commented Oct 11, 2023

@atapas I got around this message:

image

However building still fails so I can't deploy my changes to netlify which is the reason why you don't see my changes at https://deploy-preview-1321--reactplayio.netlify.app/

This is the building fail log on netlify:
image

image

I built the app locally and served it. This is the result I get:
image

As you can see my changes work just fine.

But also if I build the app locally I get this warning message:
image

So to sum it up: My changes work but I can't deploy them to netlify. What should I do now?

@atapas
Copy link
Member

atapas commented Oct 11, 2023

@FreemRL I have kicked off the build.. will check in a while.

package.json Show resolved Hide resolved
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good.

@atapas atapas merged commit a0c5c76 into reactplay:main Oct 11, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Show GitHub Star Count in formatted way
3 participants