-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated GitHub star count number format #1321
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @FreemRL I do not see the change reflecting in the preview build above. |
Okay I forgot to change it at |
I can't deploy my changes at Netlify: I think therefor it can't be shown in the deploy preview. Any idea how I can fix the deploy on Netlify? @atapas |
Hey , i had checked this issue, where i go to api endpoint on browser, it till says 1093 instead of real count. |
@atapas I got around this message: However building still fails so I can't deploy my changes to netlify which is the reason why you don't see my changes at https://deploy-preview-1321--reactplayio.netlify.app/ This is the building fail log on netlify: I built the app locally and served it. This is the result I get: As you can see my changes work just fine. But also if I build the app locally I get this warning message: So to sum it up: My changes work but I can't deploy them to netlify. What should I do now? |
@FreemRL I have kicked off the build.. will check in a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looking good.
Description
I changed the GitHub star count number format to show numbers in a more efficient way --> e.g.
1.1K
,1.1M
etc.Fixes #1320
Type of change
How Has This Been Tested?
I used the development server to test functionality.
yarn start
.Checklist:
Screenshots or example output
Before:
After: