Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to the play card on the home page #1478

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Siddharth-Dagar-25
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Implemented a solution for the visibility issue by adding a border and a hover effect to each card on the homepage. This change has significantly improved the ability to distinguish between the cards, making navigation and identification much clearer.

Fixes #1477

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I test it on my local machine, it is a css modification and is working fine.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Screenshot 2024-03-06 at 5 06 06 PM Screenshot 2024-03-06 at 5 07 04 PM

Signed-off-by: Siddharth Dagar <[email protected]>
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 4733d69
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65e855ac6ffd3d00082ca17a
😎 Deploy Preview https://deploy-preview-1478--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal added the 🛠 goal: fix Bug fix label Mar 7, 2024
@priyankarpal priyankarpal merged commit 2ec295d into reactplay:main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: add border to the play card on the home page
2 participants