Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Integration Test #230

Closed

Conversation

zunda-pixel
Copy link

🧰 Changes

Add Swift Integration Test

@zunda-pixel zunda-pixel force-pushed the add-swift-integration-test branch 7 times, most recently from d690e7b to e201968 Compare April 13, 2024 23:03
@zunda-pixel
Copy link
Author

The HTTP (non-SSL) test passed, but the HTTPS test failed.
Maybe swift.Dockerfile has SSL issue
I can't resolve it.

${readFileSync(fixturePath, 'utf8')}
`,
);
return shell.execSync(`swift ${filePath}`);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
file name
.

},
swift: (fixturePath: string) => {
const filePath = `/tmp/${path.basename(fixturePath)}`;

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
is later used in a
shell command
.
${readFileSync(fixturePath, 'utf8')}
`,
);
return shell.execSync(`swift ${filePath}`);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
is later used in a
shell command
.
@zunda-pixel
Copy link
Author

The HTTP (non-SSL) test passed, but the HTTPS test failed. Maybe swift.Dockerfile has SSL issue I can't resolve it.

I found same issue Handling self-signed certificates in URLAuthenticationChallenge on Linux.

@zunda-pixel
Copy link
Author

I need fix Swift(for Linux) or workarounds.

@erunion
Copy link
Member

erunion commented Apr 23, 2024

No worries, thanks for taking a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants