Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support event services that work with Unity's EventSystem #20

Merged
merged 6 commits into from
Aug 19, 2022

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Aug 19, 2022

Reality Collective - Reality Toolkit Pull Request

Overview

Ported over the event services from the toolkit as part of the migration. While currently this is only needed by the toolkit, I can see how it may be useful to others creating services with the framework.

Changes

  • Add support for event services
  • Fix possible NRE in service profile inspector
  • Fix log message would not contain the actual type name but always log a useless "dataProvider" string
  • Fix inspector logo pixelation and use horizontal collective logo to save vertical screen space

Breaking Changes

None

Manual testing status

Manually tested for regressions

@FejZa FejZa merged commit ddb1008 into development Aug 19, 2022
@FejZa FejZa deleted the feature/base-event-service branch August 19, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants