Fix wrong interface type returned for service regiatration

[FejZa]

Reality Collective - Reality Toolkit Pull Request

Overview

TypeExtensions.FindServiceInterfaceType returns the wrong interface type for a data provider when there is a more concrete type. This is actually the issue I was reporting the other day. So following scenario, here is the interface hierarchy for the toolkit's teleport providers:

IDashTeleportProvider -> ITeleportLocomotionProvider -> ILocomotionProvider
IBlinkTeleportProvider -> ITeleportLocomotionProvider -> ILocomotionProvider
IInstantTeleportProvider -> ITeleportLocomotionProvider -> ILocomotionProvider

Upon service registration TypeExtensions.FindServiceInterfaceType currently returns ITeleportLocomotionProvider for all three of them, which obbviously leads to issues as the service container will only register the first one and then fail to register the others since a type of that interface is already registered.
This is because Tyle.GetInterfaces() returns interfaces in an arbitrary order
And then whatever is the first one in the returned array that works for the service is seledcted
Which might not be the best suited candidate

Manual testing status

Manually tested.

[SimonDarksideJ]

Interestingly this is one issue I've been working through on and off, so I'm curious to see if this resolves it.

However, you also need to test this on different platforms, not just editor. As I've found Unity REORDERS the type list depending on platform.

Can you supply test results on different platforms, e.g. Windows / UWP / Android?

[SimonDarksideJ]

Tested here with some of our trickier edge cases and this works like a charm