Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock visualizer when moving and rename component #148

Merged
merged 7 commits into from
Jan 4, 2025

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Jan 3, 2025

Reality Collective - Reality Toolkit Pull Request

Overview

For more clarity the LockControllerVisualizerBehaviour has been renamed to HoldOntoBehaviour as that is essentially what it does. It simulates the user holding onto something (the interactable).

Also fixes smoothing calculation issues when the rig is moving while transitioning.

@FejZa FejZa requested a review from SimonDarksideJ as a code owner January 3, 2025 23:06
Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot believe how much work it was to get the runners up and running again, but fixed now. Approved

@FejZa FejZa merged commit 97c48a3 into development Jan 4, 2025
9 of 10 checks passed
@FejZa FejZa deleted the feature/fix-lock-visualizer-when-moving branch January 4, 2025 14:07
@FejZa
Copy link
Contributor Author

FejZa commented Jan 4, 2025

Thanks @SimonDarksideJ. What was going on?

@SimonDarksideJ
Copy link
Contributor

New year blues I guess, out with the old and in with the new 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants