[wip] upgrade to [email protected] #565
Conversation
dignifiedquire
force-pushed
the
feat-iroh-33
branch
from
8cdaba7 to
cfb1a3a
Compare
dignifiedquire
force-pushed
the
feat-iroh-33
branch
from
490bba1 to
595557f
Compare
dignifiedquire
changed the title
why do new files need to include Protocol Labs in the headers? |
it's just a check inherited from upstream |
Makefile
Outdated
| run-devnet-fendermint: | ||
| rm -rf ~/.fendermint/data/rocksdb | ||
| FM_NETWORK=test \ | ||
| FM_TRACING__CONSOLE__LEVEL=info,fendermint=debug,recall_executor=debug \ | ||
| FM_VALIDATOR_KEY__PATH=keys/validator.sk \ | ||
| FM_VALIDATOR_KEY__KIND=regular \ | ||
| FM_RESOLVER__CONNECTION__LISTEN_ADDR=/ip4/127.0.0.1/tcp/3001 \ | ||
| ./target/release/fendermint run --iroh-addr 127.0.0.1:4919 | ||
| ./target/release/fendermint run --iroh-path iroh-resolver-path # TODO: what path |
There was a problem hiding this comment.
not sure what path to use here, please advise
There was a problem hiding this comment.
for devnet, I think .config/recall/data/iroh makes sense. I guess we need two paths right? one for each iroh instance. .config/recall/data/iroh-staging and .config/recall/data/iroh-chain ?
for the 3-node localnet setup, i can help there... it's kind of a pain to deal with the cargo make scripts
There was a problem hiding this comment.
for the 3-node localnet setup, i can help there... it's kind of a pain to deal with the cargo make scripts
I think I have that part figured out, but definitely needs review 😅
| // this env var must be set for the blobs_syscall to work. the CLI has a default and accepts | ||
| // an override via the env variable, but it doesn't require it's set, so we ensure it here | ||
| std::env::set_var("IROH_SYSCALL_PATH", self.iroh_path.clone()); | ||
| run(settings, self.iroh_path.clone()).await |
There was a problem hiding this comment.
TODO: this will not work, as this will result in a second iroh instance trying to access an already running iroh setup
Upgrade iroh to the latest version of
0.34.See #557 for the original design discussion.
Closes #557
Current Design
https://number-zero.notion.site/recall-iroh-0-33-upgrade-1b95df1306fb8066be57dfa7b49fae1f?pvs=4
Notes
This includes a breaking wire change for iroh, so all participants need to use the latest version of this, once merged.
The change is the usage of raw public keys in the TLS setup, for details you can check out https://www.iroh.computer/blog/iroh-0-34-0-raw-public-keys
Related PRs
Open Tasks