-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ci using localnet image #237
Conversation
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
DOCKER_USERNAME: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
DOCKER_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD }} | ||
TEST_TARGET_NETWORK: localnet | ||
RECALL_PRIVATE_KEY: "0xdbda1821b80551c9d65939329250298aa3472ba22feea921c0cf5d620ea67b97" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to generate a new private key every time? So that we avoid the situations when something works with aaa
but fails with bbb
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's chat about this one. I'll need some guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created ticket #242
ci/main.go
Outdated
WithExec([]string{ | ||
"mkdir", "-p", "/root/.config/recall", | ||
}). | ||
WithExec([]string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we extract all *Exec
calls into our own docker image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what do you mean by our own image in this context? Do you mean use the a base container with all the right tooling, and separate out the code that executes our specific commands? Or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought maybe create our own image so that we do not need to run apt update
and apt install
on every test. But it's a minor one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created ticket #241
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 🚀
Signed-off-by: Mohsin Zaidi <[email protected]>
Signed-off-by: Mohsin Zaidi <[email protected]>
This PR adds plumbing to setup a
localnet
Docker container and run tests against it. A single sample test using the Recall CLI is included.To be able to integrate with the SDK, we'll have to update the SDK (in a separate PR) to be able to use configuration from the environment.
The Dagger plumbing allows many other CI combinations to be integrated (e.g. bash scripts, or other test containers, etc.)
Closes #183.