Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert monkey activity 🐒 into a fragment monke 🦍 #1576

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IndusAryan
Copy link
Contributor

new easter egg animation that mimics android 4.3 jelly bean, monkes come, float and go , dragging them removes them
go right and go left anim to make it look like activity (new screen)
using lifecycle scope (removed handler runnable) and nulling binding to release resources
fragment is lightweight

# Conflicts:
#	app/src/main/AndroidManifest.xml
#	app/src/main/java/com/lagradost/cloudstream3/ui/EasterEggMonkeActivity.kt
#	app/src/main/java/com/lagradost/cloudstream3/ui/settings/SettingsGeneral.kt
#	app/src/main/res/navigation/mobile_navigation.xml
@fire-light42
Copy link
Collaborator

Truly the most important feature 🔥 🔥 🔥

Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. UI: The cloud_2_gradient_beta is too big I suggest just removing it
  2. UX: Dragging a monke only changes its x location, not y after releasing it.

@IndusAryan
Copy link
Contributor Author

  1. UI: The cloud_2_gradient_beta is too big I suggest just removing it

    1. UX: Dragging a monke only changes its x location, not y after releasing it.

Improved DRAG, now the monkes displace on touch where we release finger instead of going back.
Move in all directions.
I have hidden system bars on view create, and reshow them when fragment destroys, this feels immersive
removed the big icon

@IndusAryan IndusAryan requested a review from fire-light42 March 1, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants