Skip to content

Commit

Permalink
Merge pull request #1606 from microsoft/miguel/pymanopt
Browse files Browse the repository at this point in the history
Issue with pymanopt
  • Loading branch information
miguelgfierro authored Jan 12, 2022
2 parents f4636b2 + 5134acc commit 7af6edd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions SETUP.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ This document describes how to setup all the dependencies to run the notebooks i
* [Azure Databricks](https://azure.microsoft.com/en-us/services/databricks/)
* Docker container


## Table of Contents

- [Compute environments](#compute-environments)
Expand Down Expand Up @@ -397,7 +396,7 @@ You can then open the Jupyter notebook server at http://localhost:8888

The process of making a new release and publishing it to pypi is as follows:

First make sure that the tag that you want to add, e.g. `0.6.0`, is added in [recommenders.py/`__init__.py`](recommenders.py/__init__.py). Follow the [contribution guideline](CONTRIBUTING.md) to add the change.
First make sure that the tag that you want to add, e.g. `0.6.0`, is added in [`recommenders.py/__init__.py`](recommenders.py/__init__.py). Follow the [contribution guideline](CONTRIBUTING.md) to add the change.

1. Make sure that the code in main passes all the tests (unit and nightly tests).
1. Create a tag with the version number: e.g. `git tag -a 0.6.0 -m "Recommenders 0.6.0"`.
Expand Down
1 change: 1 addition & 0 deletions tests/integration/examples/test_notebooks_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ def test_cornac_bpr_integration(


@pytest.mark.integration
@pytest.mark.experimental
@pytest.mark.parametrize(
"expected_values",
[({"rmse": 0.4969, "mae": 0.4761})],
Expand Down

0 comments on commit 7af6edd

Please sign in to comment.