remove the init container that decides the allowing of reconciliation of manager

[rewantsoni]

With convergence, the ocs-operator will always deploy the ocs-client-op, thus we no longer need the deployment guard.

This PR removes the deployment-guard init container

[rewantsoni]

/hold for testing

[leelavg]

did you try reverting commits from these PRs in reverse order? #196, #198, #208, the expectation after revert should be a clean branch w/ no merge conflicts.

[rewantsoni]

I didn't try a revert because of https://github.com/red-hat-storage/ocs-client-operator/pull/196/files#diff-5fc35123fcf790367bb280d63e74ddb015a7393edde91df0ebb77eb7e9f90f18L10, we are updating the operator-sdk version and kubebuilder version

[leelavg]

ack, then you can add a commit to explicitly fix them/those, anyways pls choose whatever works for you.

[leelavg]

@rewantsoni what's pending on this?

[rewantsoni]

@leelavg I could not test as I was busy due to 4.18 RC. I will test it today and update

[rewantsoni]

Testing:

Ran make deploy to install the operator
[rewantsoni work] k get po -n ocs-client-operator-system ocs-client-operator-controller-manager-df596664c-4jkbk -o json | jq '.spec.containers[].name'
"kube-rbac-proxy"
"manager"

The deployment-guard controller no longer exists

[leelavg]

/hold if more votes are required.
after merge to 4.19 we need to update d/s Dockerfile.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [leelavg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Madhu-1]

We can merge this change once a disable Rook csi deployment in ocs-operator or in Rook CSV irrespective of modes