Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: update the replicationID for ramen #3026

Merged
merged 1 commit into from
Feb 11, 2025
Merged

provider: update the replicationID for ramen #3026

merged 1 commit into from
Feb 11, 2025

Conversation

rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Feb 10, 2025 •
edited
Loading

Ramen's replication ID is combination of storageIDs.

storageID is a combination of cephfsid,cephblockpool id and the rns name
To generate the peerStorageID,

  • use the blockpool's mirroring token to get the peer cephfsid.
  • to the cephblockpool id from the peer cluster, use the annotation on the blockpool
  • use the rns.Spec.Mirroring.RemoteNamespace to fetch the remote namespace

@rewantsoni rewantsoni force-pushed the replicationID branch 2 times, most recently from 8767965 to 19d9795 Compare February 10, 2025 18:25
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@rewantsoni rewantsoni force-pushed the replicationID branch 2 times, most recently from bed3206 to 20451e0 Compare February 11, 2025 08:30
nb-ohad
nb-ohad requested changes Feb 11, 2025
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the replicationID branch 3 times, most recently from 8e85956 to c0e4448 Compare February 11, 2025 15:45
nb-ohad
nb-ohad requested changes Feb 11, 2025
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the replicationID branch 4 times, most recently from fe045fc to 15c15ee Compare February 11, 2025 16:24
nb-ohad
nb-ohad requested changes Feb 11, 2025
View reviewed changes
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the replicationID branch 2 times, most recently from f28cdd2 to 2230eed Compare February 11, 2025 16:54
nb-ohad
nb-ohad requested changes Feb 11, 2025
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@rewantsoni: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nb-ohad
Copy link
Contributor

nb-ohad commented Feb 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b593c6f into red-hat-storage:main Feb 11, 2025
11 checks passed
@openshift-cherrypick-robot
Copy link

@rewantsoni: new pull request created: #3034

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nb-ohad nb-ohad nb-ohad requested changes

Assignees

@nb-ohad nb-ohad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rewantsoni @openshift-cherrypick-robot @nb-ohad @openshift-merge-robot