Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-1323: [release-4.18] provider: update the storageID for ramen #3032

Merged

Conversation

rewantsoni
Copy link
Member

This is a manual backport of #3008

The automated backport was failing due to linter issue: #3031

update ramen storageID to be:
for rbd: combination(cephCluster_FSID,blockpool_id,rns_name)
for cephfs: combination(cephCluster_FSID,filesystem_name,svg_name)

Signed-off-by: Rewant Soni <[email protected]>
(cherry picked from commit e6c698a)
Signed-off-by: Rewant Soni <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/severity-important jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Feb 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025

@rewantsoni: This pull request references [Jira Issue DFBUGS-1323](https://issues.redhat.com//browse/DFBUGS-1323), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

This is a manual backport of #3008

The automated backport was failing due to linter issue: #3031

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rewantsoni: This pull request references [Jira Issue DFBUGS-1323](https://issues.redhat.com//browse/DFBUGS-1323), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

This is a manual backport of #3008

The automated backport was failing due to linter issue: #3031

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nb-ohad
Copy link
Contributor

nb-ohad commented Feb 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d013f5c into red-hat-storage:release-4.18 Feb 11, 2025
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025

@rewantsoni: [Jira Issue DFBUGS-1323](https://issues.redhat.com//browse/DFBUGS-1323): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1323](https://issues.redhat.com//browse/DFBUGS-1323) has been moved to the MODIFIED state.

In response to this:

This is a manual backport of #3008

The automated backport was failing due to linter issue: #3031

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants