Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-1509: [release-4.18] Use Required Pod anti affinity if Active MDS is not more than 1 #3036

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3035

/assign malayparida2000

When Active MDS is 1, there would be 2 mds pods & we want them to be
scheduled on different nodes always. So we use the required pod
anti-affinity. If Active MDS are more than 1 then in a 3 node cluster
scheduling issues would be there, so we switch to using preferred
anti-affinity.

Signed-off-by: Malay Kumar Parida <[email protected]>
@malayparida2000 malayparida2000 changed the title [release-4.18] Use Required Pod anti affinity if Active MDS is not more than 1 DFBUGS-1509: [release-4.18] Use Required Pod anti affinity if Active MDS is not more than 1 Feb 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Feb 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2025

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1509](https://issues.redhat.com//browse/DFBUGS-1509), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #3035

/assign malayparida2000

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@malayparida2000
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Feb 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2025

@malayparida2000: This pull request references [Jira Issue DFBUGS-1509](https://issues.redhat.com//browse/DFBUGS-1509), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@malayparida2000 malayparida2000 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: malayparida2000, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5fdd53b into red-hat-storage:release-4.18 Feb 13, 2025
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2025

@openshift-cherrypick-robot: [Jira Issue DFBUGS-1509](https://issues.redhat.com//browse/DFBUGS-1509): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1509](https://issues.redhat.com//browse/DFBUGS-1509) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3035

/assign malayparida2000

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@malayparida2000
Copy link
Contributor

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Author

@malayparida2000: #3036 failed to apply on top of branch "release-4.17":

Applying: Use Required Pod anti affinity if Active MDS is not more than 1
Using index info to reconstruct a base tree...
M	controllers/defaults/placements.go
M	controllers/storagecluster/placement.go
M	controllers/storagecluster/placement_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/storagecluster/placement_test.go
CONFLICT (content): Merge conflict in controllers/storagecluster/placement_test.go
Auto-merging controllers/storagecluster/placement.go
Auto-merging controllers/defaults/placements.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Use Required Pod anti affinity if Active MDS is not more than 1

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants