Enhance MirrorPeer and S3 Secret Handling and other bug fixes #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vbnrh
commented
Nov 18, 2024
vbnrh
commented
- Updated MirrorPeerReconciler to accurately handle storage client references and added deleteMirrorPeer conditional to account for provider mode.
- Introduced annotation support in ObjectBucketClaim for dynamic setting based on MirrorPeer type.
- Added new constants and enums for OBC types and annotations to enhance readability and standardize key usage.
- Enhanced S3 secret synchronization logic to differentiate between client and cluster references, fetching relevant storage cluster info per context.
- Refined ConfigMap client information updates with new GetKey helper and corrected test cases for compatibility.
- Implemented FetchMirrorPeerByName for efficient MirrorPeer retrieval by name.
- Modified utility methods for secret and config map creation to handle namespace variations, ensuring correct retrieval in provider-client contexts.
- Refactored validation and utility methods for enhanced error handling and consistent namespace management.
rewantsoni
suggested changes
Nov 18, 2024
vbnrh
force-pushed
the
fix-mcv-controller
branch
from
a66ce7c to
3b6c8be
Compare
- Updated MirrorPeerReconciler to accurately handle storage client references and added deleteMirrorPeer conditional to account for provider mode. - Introduced annotation support in ObjectBucketClaim for dynamic setting based on MirrorPeer type. - Added new constants and enums for OBC types and annotations to enhance readability and standardize key usage. - Enhanced S3 secret synchronization logic to differentiate between client and cluster references, fetching relevant storage cluster info per context. - Refined ConfigMap client information updates with new GetKey helper and corrected test cases for compatibility. - Implemented FetchMirrorPeerByName for efficient MirrorPeer retrieval by name. - Modified utility methods for secret and config map creation to handle namespace variations, ensuring correct retrieval in provider-client contexts. - Refactored validation and utility methods for enhanced error handling and consistent namespace management. Signed-off-by: vbadrina <[email protected]>
vbnrh
force-pushed
the
fix-mcv-controller
branch
from
3b6c8be to
a3f1f26
Compare
|
Tested the build on the cluster and everything looks good,
/lgtm |
|
/unhold |
umangachapagain
approved these changes
Nov 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umangachapagain, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 17353b7
into
red-hat-storage:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.