Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHTAPINST-99: Upstream MinIO Operator #232

Merged
merged 5 commits into from
Oct 2, 2024
Merged

RHTAPINST-99: Upstream MinIO Operator #232

merged 5 commits into from
Oct 2, 2024

Conversation

otaviof
Copy link
Collaborator

@otaviof otaviof commented Sep 16, 2024

Replacing OpenShift Operator Hub MinIO subscription with their upstream Helm Chart deployment.

@otaviof otaviof added the enhancement New feature or request label Sep 16, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@otaviof: This pull request references RHTAPINST-99 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Replacing OpenShift Operator Hub MinIO subscription with their upstream Helm Chart deployment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otaviof otaviof force-pushed the RHTAPINST-99 branch 2 times, most recently from 571421f to a3384d3 Compare September 16, 2024 19:04
@otaviof
Copy link
Collaborator Author

otaviof commented Sep 17, 2024

/retest

2 similar comments
@otaviof
Copy link
Collaborator Author

otaviof commented Sep 17, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 17, 2024

/retest

@otaviof otaviof force-pushed the RHTAPINST-99 branch 2 times, most recently from 27c93f7 to 74d7122 Compare September 17, 2024 13:52
@otaviof
Copy link
Collaborator Author

otaviof commented Sep 17, 2024

/retest

7 similar comments
@otaviof
Copy link
Collaborator Author

otaviof commented Sep 17, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 18, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 18, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 18, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 18, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 18, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 18, 2024

/retest

@Roming22
Copy link
Member

/hold

@Roming22
Copy link
Member

@otaviof I propose to wait for the PRs we would want in 1.2.1 before merging that PR.

@otaviof
Copy link
Collaborator Author

otaviof commented Oct 1, 2024

/retest

@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-brx7c-mbrpb Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-brx7c-mbrpb

@Roming22
Copy link
Member

Roming22 commented Oct 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2024
@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-x7v59-6qc5z Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-x7v59-6qc5z

@Roming22
Copy link
Member

Roming22 commented Oct 1, 2024

@otaviof Something is broken

############################################################
# [3/9] Deploying 'charts/rhtap-minio-operator' in 'minio-operator'.
############################################################
Error: install failed: Unable to continue with install: ServiceAccount "minio-operator" in namespace "minio-operator" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "rhtap-minio-operator"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "minio-operator"

@otaviof
Copy link
Collaborator Author

otaviof commented Oct 2, 2024

/retest

@openshift-ci openshift-ci bot removed the lgtm label Oct 2, 2024
@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-77kqr-hrvkn Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-77kqr-hrvkn

@otaviof
Copy link
Collaborator Author

otaviof commented Oct 2, 2024

/retest

@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-tltzq-wc2tp Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-tltzq-wc2tp

@otaviof
Copy link
Collaborator Author

otaviof commented Oct 2, 2024

/retest

@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-977fw-dc68m Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-977fw-dc68m

@otaviof
Copy link
Collaborator Author

otaviof commented Oct 2, 2024

/retest

@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-lhffl-rwksk Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-lhffl-rwksk

@Roming22 Roming22 mentioned this pull request Oct 2, 2024
Merged
@konflux-ci-qe-bot
Copy link

@otaviof: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
rhtap-cli-vzm2x-fhv4v Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:rhtap-cli-vzm2x-fhv4v

@otaviof
fix: Service Account Name vs. Workaround
158abd7 
Making sure the service account name doesn't colide with the installer.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
4 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Roming22
Copy link
Member

Roming22 commented Oct 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 781b2fb into redhat-appstudio:main Oct 2, 2024
9 checks passed
@otaviof otaviof deleted the RHTAPINST-99 branch October 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roming22 Roming22 Roming22 approved these changes

@jkopriva jkopriva Awaiting requested review from jkopriva

@flacatus flacatus Awaiting requested review from flacatus

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@Roming22 Roming22

Labels
approved enhancement New feature or request lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otaviof @openshift-ci-robot @Roming22 @konflux-ci-qe-bot