Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHTAPINST-145: Windows Executable #239

Merged
merged 2 commits into from
Oct 2, 2024
Merged

RHTAPINST-145: Windows Executable #239

merged 2 commits into from
Oct 2, 2024

Conversation

otaviof
Copy link
Collaborator

@otaviof otaviof commented Sep 19, 2024

Plus documentation to describe more about goreleaser usage.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 19, 2024 •
edited by openshift-ci bot
Loading

@otaviof: This pull request references RHTAPINST-145 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Plus documentation to describe more about goreleaser usage.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 19, 2024

/retest

@Roming22
Copy link
Member

@otaviof Please add some text about how deployment is not compatible with Windows.

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 20, 2024

@otaviof Please add some text about how deployment is not compatible with Windows.

Please consider latest changes.

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 20, 2024

/retest

16 similar comments
@otaviof
Copy link
Collaborator Author

otaviof commented Sep 20, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 20, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 20, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 21, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 22, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 23, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 23, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 24, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 25, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 25, 2024

/retest

@xinredhat
Copy link
Member

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 25, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 25, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 26, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Sep 30, 2024

/retest

@otaviof
Copy link
Collaborator Author

otaviof commented Oct 1, 2024

/retest

@otaviof otaviof force-pushed the RHTAPINST-145 branch 2 times, most recently from 8e7c744 to 96ca3d8 Compare October 1, 2024 14:28
@Roming22
Copy link
Member

Roming22 commented Oct 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2024
@Roming22
Copy link
Member

Roming22 commented Oct 1, 2024

/retest

@otaviof
feat: Windows Executable
fec5040 
Plus documentation to describe more about `goreleaser` usage.
@otaviof
docs: Installation Instructions and Hook Scripts
1524314 
Covering the details related to Windows native environments about WSL
and hook scripts.
@openshift-ci openshift-ci bot removed the lgtm label Oct 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Roming22
Roming22 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2eed7cd into redhat-appstudio:main Oct 2, 2024
9 checks passed
@otaviof otaviof deleted the RHTAPINST-145 branch October 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roming22 Roming22 Roming22 approved these changes

@jduimovich jduimovich Awaiting requested review from jduimovich

@flacatus flacatus Awaiting requested review from flacatus

@xinredhat xinredhat Awaiting requested review from xinredhat

Assignees

@Roming22 Roming22

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otaviof @openshift-ci-robot @Roming22 @xinredhat