Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream name mismatch in code and the text #2555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sJJdGG
Copy link

@sJJdGG sJJdGG commented Sep 30, 2023

in the code above the suggested diff, the stream name is race:france which is coherent with all the other example in the doc. but it's wrongly named mystream

in the code above the suggested diff, the stream name is `race:france` which is coherent with all the other example in the doc. but it's wrongly named `mystream`
@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for redis-doc ready!

Name Link
🔨 Latest commit cdfef49
🔍 Latest deploy log https://app.netlify.com/sites/redis-doc/deploys/6538316a6a478c0008f0bd8b
😎 Deploy Preview https://deploy-preview-2555--redis-doc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dwdougherty
Copy link
Collaborator

Thank you, Sajjad, for the PR.

There are two other occurrences of "mystream" that need to be changed. The first is in the same paragraph you mentioned, line 329. The other is on line 435, where "mystream" should be changed to "race:italy". Can you make these other two changes to this PR?

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dwdougherty
❌ sJJdGG
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants