Add LRU Cache for DotPathToSlice #1890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve McDaniel <[email protected]>
Signed-off-by: Steve McDaniel <[email protected]>
Signed-off-by: Steve McDaniel <[email protected]>
Signed-off-by: Steve McDaniel <[email protected]>
|
Can we get some benchmark tests that show the before/after? Ideally with a realistic config, maybe as an addition to https://github.com/benthosdev/benthos/blob/main/public/service/benchmark_test.go#L17 I'm little hesitant to add caches in deep areas of the codebase and a lot of these changes are in places I'd expect to be cold paths. |
|
Perhaps we can discuss merging my PR in gabs instead Jeffail/gabs#136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache DotPathToSlice results to avoid allocations and str repls.
Reduces memory allocations and reduces CPU utilization in that code path by about 30%.