Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sftp): add modtime as metadata. [#2955] #2970

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danriedl
Copy link

This PR adds:

Copy link
Collaborator

@Jeffail Jeffail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @danriedl, this could end up with quite a large performance impact when there's many messages coming from individual files (unless there's some underlying caching during the stat calls). It's probably better to extract this info in the same place where we capture the currentPath, so that it's only performed once per file.

If we add more information over time it'll start looking a bit messy having all of these fields added to the sftpReader type so it'd also be good to add some sort of currentFileInfo struct that carries all of this info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants