Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues in docs #675

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59 aryaemami59 commented Jan 3, 2024

This PR:

  • Fixes createSelectorCreator Parameters inside docs
  • Makes images in docs zoomable
  • Fixes links inside README file
  • Specifies default value for dev mode checks in docs
  • Slightly modifies examples to emphasize the switch from lruMemoize to weakMapMemoize inside createSelector
  • Updates lruMemoize and weakMapMemoize documentation to clearly emphasize the change from using lruMemoize to weakMapMemoize as the default memoizer in createSelector starting from Reselect 5.0.0.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for reselect-docs ready!

Name Link
🔨 Latest commit 7b5cb3c
🔍 Latest deploy log https://app.netlify.com/sites/reselect-docs/deploys/672b84af91dfbb0008cddd8f
😎 Deploy Preview https://deploy-preview-675--reselect-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Jan 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@aryaemami59 aryaemami59 marked this pull request as ready for review January 7, 2024 13:16
@aryaemami59
Copy link
Contributor Author

FYI I will probably split this into 2 PRs, one for docs, one for JSDocs.

@aryaemami59 aryaemami59 marked this pull request as draft February 10, 2024 22:32
@aryaemami59
Copy link
Contributor Author

I haven't forgotten about this one, since it's actually important, will probably finish it sometime this week.

@aryaemami59
Copy link
Contributor Author

aryaemami59 commented Mar 17, 2024

This should be it for now, if I think of anything else, I'll open a separate PR.

@aryaemami59 aryaemami59 marked this pull request as ready for review March 17, 2024 09:14
@aryaemami59 aryaemami59 force-pushed the fix-docs branch 7 times, most recently from 72dac48 to 555d7f3 Compare August 13, 2024 02:40
@aryaemami59 aryaemami59 force-pushed the fix-docs branch 11 times, most recently from f228a2a to 22a36f2 Compare September 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant