comment-excess - Fix rare bug + improve style
#7716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems we should also match the • character. Is GitHub consistent with its usage on that line? |
|
@fregante It doesn't need to match • character. You can see |
|
I mean “match in style” not in regex. The two • in the second screenshot have different sizes. One of them is added by us and should be changed to match GitHub’s character instead. Or maybe it needs a class? |
|
Oooo, get it. |
|
Maybe just need change the character. 
|
fregante
approved these changes
Aug 21, 2024
fregante
changed the title
comment-excess - Fix rare bugcomment-excess - Fix rare bug + improve style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs
refined-github/sandbox#3
Screenshot
before:
after: