-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic changes for image presenter #3489
Open
anitagraham
wants to merge
4
commits into
refinery:main
Choose a base branch
from
anitagraham:imagePresenter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anitagraham
force-pushed
the
imagePresenter
branch
2 times, most recently
from
January 26, 2021 02:14
407a75a
to
b6adbc8
Compare
parndt
reviewed
Jul 14, 2021
parndt
reviewed
Jul 14, 2021
parndt
reviewed
Jul 14, 2021
parndt
reviewed
Jul 14, 2021
parndt
reviewed
Jul 14, 2021
parndt
reviewed
Jul 14, 2021
parndt
reviewed
Jul 14, 2021
@@ -1,6 +1,7 @@ | |||
source 'https://rubygems.org' | |||
|
|||
gemspec | |||
gem 'rails', '~>6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think so. I'll remove and test again.
parndt
reviewed
Jul 14, 2021
. ensure markup is identical for each view as far as possible . Use css-grid to prevent image title/file name overwriting icons . Add locale markers to images in grid view
…ruby is deprecated Merge imagePresenter and collectionPresenter. Tests pass.
anitagraham
force-pushed
the
imagePresenter
branch
from
October 18, 2021 06:16
ad436ec
to
820b1b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a precursor to another one that I have ready to go, but it doesn't fit in the scope of that PR.
Before
'refinery/images/index' can present two different views of the images: list-view and grid-view.
The code to do this was split over several files, and there wasn't much congruence between the code for the two views, though the final markup was not much different.
In the process of implementing a small change to the UI ('click to edit') I have rewritten the index view so that both views use the same code, with a single difference between them.
Now
The image and list views look much the same as they did, with some markup and styling changes.
The markup for the image index is now generated by the same code whether the user has selected List View or Image View.
The appearance of the views has not changed significantly, but the markup/styling to achieve that has.
Note 1: Gemfile:
Use refinerycms-wymeditor, branch: master
Note 2:
The images do have 'click to edit'. That is, to edit an image click on any of
Screenshots