Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app_module_for_backend #4749

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove app_module_for_backend #4749

wants to merge 2 commits into from
+26 −51

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Feb 4, 2025

  • Replace app_module_for_backend with ASGI factory on rx.App.__call__
  • Consolidate module spec for uvicorn, gunicorn, and granian

@masenf
Remove app_module_for_backend
78277af 
* Replace app_module_for_backend with ASGI factory on `rx.App.__call__`
* Consolidate module spec for uvicorn, gunicorn, and granian
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4749 will not alter performance

Comparing masenf/remove-app-module-for-backend (0e45cc5) with main (b3b79a6)

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masenf @Lendemor