remove rich #5033
remove rich #5033
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodSpeed Performance ReportMerging #5033 will not alter performanceComparing Summary
|
| @staticmethod | ||
| def _moveup(lines: int): | ||
| for _ in range(lines): | ||
| sys.stdout.write("\x1b[A") |
There was a problem hiding this comment.
should this kind of stuff go to stderr? or maybe take a stream field so its easier to change later
There was a problem hiding this comment.
does windows even support these ANSI codes reliably?
rich was at least giving us a cross platform abstraction
There was a problem hiding this comment.
it's not per OS, more like, per terminal
| @@ -113,7 +117,9 @@ def run_process_and_launch_url( | |||
| url = urljoin(url, get_config().frontend_path) | |||
|
|
|||
| console.print( | |||
| f"App running at: [bold green]{url}[/bold green]{' (Frontend-only mode)' if not backend_present else ''}" | |||
| "App running at: " | |||
| + colored(url, "green", attrs=("bold",)) | |||
There was a problem hiding this comment.
underline on the link would be nice
| msg = colored(msg, color, attrs=["bold"] if bold else []) | ||
|
|
||
| if IS_REPRENTER_ACTIVE: | ||
| print("\n" + msg, flush=True, **kwargs) # noqa: T201 |
There was a problem hiding this comment.
this doesn't seem like quite the right logic. it causes a bunch of log lines interleaved with status messages. in rich the printed lines seem to go above the status line without leaving artifacts.
There was a problem hiding this comment.
this doesn't seem like quite the right logic. it causes a bunch of log lines interleaved with status messages. in rich the printed lines seem to go above the status line without leaving artifacts.
this is actually not my experience, in mine i get double progress bars whenever i hit a deprecation warning or such, with rich
|
overall i'm a little hesitant on this change still. 
it needs more testing on different platforms and with different log levels |
there are a few remaining [bold]