Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start work on type things #1218

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

CJ-Wright
Copy link
Member

I'm not certain if this can go in. It certainly doesn't pass all of mypy at this point.
My hope is that it does help to clarify some of the types, especially when something is a package name or not.

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #1218 into master will decrease coverage by 51.46%.
The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #1218       +/-   ##
==========================================
- Coverage   58.80%   7.33%   -51.47%     
==========================================
  Files          58      58               
  Lines        5578    5713      +135     
==========================================
- Hits         3280     419     -2861     
- Misses       2298    5294     +2996     
Impacted Files Coverage Δ
conda_forge_tick/auto_tick.py 0.00% <0.00%> (ø)
conda_forge_tick/migrators/core.py 4.05% <0.00%> (-67.11%) ⬇️
conda_forge_tick/migrators/migration_yaml.py 0.00% <0.00%> (-56.83%) ⬇️
conda_forge_tick/utils.py 23.45% <50.00%> (-35.79%) ⬇️
conda_forge_tick/migrators/use_pip.py 0.00% <0.00%> (-96.30%) ⬇️
...a_forge_tick/migrators/conda_forge_yaml_cleanup.py 0.00% <0.00%> (-96.30%) ⬇️
tests/test_cross_compile.py 4.65% <0.00%> (-95.35%) ⬇️
conda_forge_tick/migrators/matplotlib_base.py 0.00% <0.00%> (-95.13%) ⬇️
conda_forge_tick/migrators/pip_check.py 0.00% <0.00%> (-94.96%) ⬇️
..._forge_tick/migrators/extra_jinj2a_keys_cleanup.py 0.00% <0.00%> (-94.45%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d409979...2430e27. Read the comment docs.

Co-authored-by: Marius van Niekerk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants