-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update version and build number for v2 recipes #2912
Conversation
f61819e
to
6d50d68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to move the code in this direction.
rattler-build
is an implementation of the v2 spec and possibly not the only one. Bot items like updating build numbers, version bumps, etc. should be independent of the backend spec implementation as much as possible.
If you all would like contribute to items like this to conda-recipe-manager, that'd be a way to not have them directly in this code base.
I have no problems to put the code directly in the I am not sure where you see the difference between the "rattler-build-conda-compat" and "conda-recipe-manager" packages? Is it just the name? :) |
Just to be clear - the code in |
I looked at it some more and I do think that it would be quite a lot of duplication (ie. the whole Jinja rendering logic and conditional list traversal logic would need to be duplicated). On the other hand, no problem for me to copy it over if that's the preference! :) |
My main concerns are three-fold. First, we have a proliferation of recipe editing tools / approaches. We have at least three existing approaches right now:
The first two date back to ~4 years ago and I am not sure about Second, I agree with Isuru's concern about rattler branding in general. Third, I don't like splitting code out of this repo in ways that potentially create cross-package debugging and/or cross-package release issues. Should code in the other package(s) fail, then the release process for fixes becomes more complicated. If we
then we'd be in a better spot all around. |
Closing in favor of #2920 |
We haven't actually released a new version of the
rattler-build-conda-compat
package. This can be considered a draft-PR for what it should look like.