Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Git-5) Refactor Solvability Check in auto_tick #3003

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Sep 16, 2024

Description:

Building upon #3000, this PR refactors the solvability checking code in auto_tick.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

#3000 needs to be merged first.

@ytausch ytausch changed the title (Git-5) Refactor (Git-5) Refactor Solvability Check in auto_tick Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (f2cf34b) to head (e4ee10e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/auto_tick.py 12.90% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
- Coverage   76.29%   76.26%   -0.04%     
==========================================
  Files         115      115              
  Lines       12550    12559       +9     
==========================================
+ Hits         9575     9578       +3     
- Misses       2975     2981       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You use textwrap.dedent but as far as I can tell, you have removed the import.

@ytausch
Copy link
Contributor Author

ytausch commented Sep 23, 2024

@beckermr I think you were mislead here. I have removed the (somewhat redundant) import from textwrap import dedent but there is still a import textwrap import which is used. No import errors here.

@beckermr
Copy link
Contributor

Ack I missed that. Thank you and LGTM!

@beckermr beckermr merged commit b2b4e14 into regro:main Sep 23, 2024
7 of 8 checks passed
@ytausch ytausch deleted the continue-git-backend-part-5 branch September 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants