Add test of dashboard PR#7
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keigohtr
requested review from
sugyan,
yoquankara,
yustoris,
jkw552403,
yuki-mt and
shimpei-yotsukura
yoquankara
reviewed
Aug 27, 2018
| # Check Kubernetes dump files | ||
| aobj = Application.query.filter_by( | ||
| kubernetes_id=kobj.kubernetes_id).one_or_none() | ||
| if aobj is not None: |
There was a problem hiding this comment.
Can't we assert aobj is not None here?
There was a problem hiding this comment.
No we can't.
I have noticed that this aobj is always None.
So we can remove this # Check Kubernetes dump files section.
There was a problem hiding this comment.
Yeah, let's remove this section!
|
@yoquankara |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add test of
dashboardPR#7rekcurd/dashboard#7
This PR includes
What type of PR is it?
Feature
What is the issue?
N/A
How should this be tested?
Run unit test.