Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quay.io/konflux-ci/yq as a base image #106

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ralphbean
Copy link
Member

We agreed that it is permissible because it is built hermetically.

We agreed that it is permissible because it is built hermetically.
@ralphbean ralphbean requested a review from rhartman93 as a code owner January 30, 2025 13:52
Copy link
Contributor

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If images are built hermetically, we know that all dependencies are known. If there are any issues in the use of this image, it becomes the responsibility of the consumer to respond to potential vulnerabilities.

arewm added a commit to konflux-ci/yq-container that referenced this pull request Jan 30, 2025
We are proposing to add yq-container as an acceptable base image because this is built hermetically. We should add redundancy to the owners.

ref: release-engineering/rhtap-ec-policy#106
@p-rog
Copy link

p-rog commented Jan 30, 2025

If images are built hermetically, we know that all dependencies are known. If there are any issues in the use of this image, it becomes the responsibility of the consumer to respond to potential vulnerabilities.

Well... first it's the code owner responsibility to address the vulnerability in the base image, then it's consumer responsibility to consume new version of the YQ base image and rebuild the final image.

Nevertheless, we want to have such base images :)

@ralphbean ralphbean merged commit 88904ac into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants