Allows cachi2 downloads from indy.corp.redhat.com #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configures EC policy to allow download from any repository on
indy.corp.redhat.com, I dont know if this is too wide, perhaps it needs
to be narrower, e.g. scoped to
indy.corp.redhat.com/api/content/maven/hosted/pnc-builds
|
@rhartman93, @ralphbean created this as an example, folk on the RHOAI team use cachi2 generic download to fetch dependencies like this. |
kosciCZ
suggested changes
Nov 25, 2024
| --- | ||
| rule_data: | ||
| allowed_package_sources: | ||
| - type: generic |
There was a problem hiding this comment.
Suggested change
| - type: generic | |
| - type: maven |
Hey, cachi2 now supports fetching maven artifacts directly and reporting them as such in the SBOM. If users used the generic functionality to download maven artifacts, they should migrate to the maven ones, as the indy.corp.redhat.com only hosts those.
There was a problem hiding this comment.
Please reach out to @dchourasia and @MohammadiIram to discuss this
There was a problem hiding this comment.
As for narrowing the url, cc @aloubyansky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures EC policy to allow download from any repository on indy.corp.redhat.com, I dont know if this is too wide, perhaps it needs to be narrower, e.g. scoped to