Strip search params from FOW path parameter (#12899)

remix-run · Jan 29, 2025 · 1656374 · 1656374
1 parent ea5a265
commit 1656374
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 2 deletions.
diff --git a/.changeset/honest-socks-fail.md b/.changeset/honest-socks-fail.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/router": patch
+---
+
+Strip search parameters from `patchRoutesOnNavigation` `path` param for fetcher calls
diff --git a/packages/router/__tests__/lazy-discovery-test.ts b/packages/router/__tests__/lazy-discovery-test.ts
@@ -2435,5 +2435,76 @@ describe("Lazy Route Discovery (Fog of War)", () => {
       expect(router.getFetcher(key).state).toBe("idle");
       expect(router.getFetcher(key).data).toBe("C ACTION");
     });
+
+    it("does not include search params in the `path` (fetcher.load)", async () => {
+      let capturedPath;
+
+      router = createRouter({
+        history: createMemoryHistory(),
+        routes: [
+          {
+            path: "/",
+          },
+          {
+            id: "parent",
+            path: "parent",
+          },
+        ],
+        async patchRoutesOnNavigation({ path, patch }) {
+          capturedPath = path;
+          patch("parent", [
+            {
+              id: "child",
+              path: "child",
+              loader: () => "CHILD",
+            },
+          ]);
+        },
+      });
+
+      let key = "key";
+      router.fetch(key, "0", "/parent/child?a=b");
+      await tick();
+      expect(router.getFetcher(key).state).toBe("idle");
+      expect(router.getFetcher(key).data).toBe("CHILD");
+      expect(capturedPath).toBe("/parent/child");
+    });
+
+    it("does not include search params in the `path` (fetcher.submit)", async () => {
+      let capturedPath;
+
+      router = createRouter({
+        history: createMemoryHistory(),
+        routes: [
+          {
+            path: "/",
+          },
+          {
+            id: "parent",
+            path: "parent",
+          },
+        ],
+        async patchRoutesOnNavigation({ path, patch }) {
+          capturedPath = path;
+          patch("parent", [
+            {
+              id: "child",
+              path: "child",
+              action: () => "CHILD",
+            },
+          ]);
+        },
+      });
+
+      let key = "key";
+      router.fetch(key, "0", "/parent/child?a=b", {
+        formMethod: "post",
+        formData: createFormData({}),
+      });
+      await tick();
+      expect(router.getFetcher(key).state).toBe("idle");
+      expect(router.getFetcher(key).data).toBe("CHILD");
+      expect(capturedPath).toBe("/parent/child");
+    });
   });
 });
diff --git a/packages/router/router.ts b/packages/router/router.ts
@@ -2264,7 +2264,7 @@ export function createRouter(init: RouterInit): Router {
     if (isFogOfWar) {
       let discoverResult = await discoverRoutes(
         requestMatches,
-        path,
+        new URL(fetchRequest.url).pathname,
         fetchRequest.signal
       );
 
@@ -2556,7 +2556,7 @@ export function createRouter(init: RouterInit): Router {
     if (isFogOfWar) {
       let discoverResult = await discoverRoutes(
         matches,
-        path,
+        new URL(fetchRequest.url).pathname,
         fetchRequest.signal
       );