Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clear button isn't clickable issue when inputting long single line text #183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed clear button isn't clickable issue when inputting long single line text #183

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74d9469
Fixed clear button isn't clickable issue when inputting long single l…
dongyuan May 3, 2015
313f3a9
Made sure the touch event is propagated when not clicking on the clea…
May 15, 2015
7dbc954
Merge pull request #1 from mickejohansson/no_keyboard_when_going_back
dongyuan May 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions library/src/main/java/com/rengwuxian/materialedittext/MaterialEditText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,8 +1469,9 @@ public boolean onTouchEvent(MotionEvent event) {
if (insideClearButton(event)) {
clearButtonTouched = true;
clearButtonClicking = true;
return true;
}
return true;
break;
case MotionEvent.ACTION_MOVE:
if (clearButtonClicking && !insideClearButton(event)) {
clearButtonClicking = false;
Expand Down Expand Up @@ -1504,8 +1505,8 @@ public boolean onTouchEvent(MotionEvent event) {
private boolean insideClearButton(MotionEvent event) {
float x = event.getX();
float y = event.getY();
int startX = getScrollX() + (iconLeftBitmaps == null ? 0 : (iconOuterWidth + iconPadding));
int endX = getScrollX() + (iconRightBitmaps == null ? getWidth() : getWidth() - iconOuterWidth - iconPadding);
int startX = iconLeftBitmaps == null ? 0 : (iconOuterWidth + iconPadding);
int endX = iconRightBitmaps == null ? getWidth() : getWidth() - iconOuterWidth - iconPadding;
int buttonLeft;
if (isRTL()) {
buttonLeft = startX;
Expand Down