feat: add support for config.js #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jan 11, 2025
|
Hi @viceice, Thank you so much for taking the time to review my PR! I’ve made the suggested changes. Please let me know if there’s anything else I should adjust or address. Looking forward to your thoughts! |
viceice
reviewed
Jan 17, 2025
viceice
approved these changes
Jan 23, 2025
|
please don't merge main branch, it'll reset PR approval |
viceice
approved these changes
Jan 29, 2025
|
Hi, you forgot to change the volume path when using a js file, it is still looking for a config.json file and therefore it does not work. |
|
I'll open an issue and make a PR with changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
configIsJavascriptfield allows the configuration to be specified in JavaScript format. When set to true, the configuration will be generated as config.js. If set to false, the configuration will be generated as config.json.Fix #2215