Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/automerge): Allow a separate schedule for automerge #15680

Merged
merged 18 commits into from
May 31, 2022

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented May 22, 2022

Changes

Added schedule support for automerge.

Context

Closes #15475

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Gabriel-Ladzaretti commented May 22, 2022

Test coverage and snapshot updates to be handled soon.

Also, I'm not quite sure where to include the automerge schedule in the PR body.
should we have it under automerge or schedule?

PR body:

This PR contains the following updates:

Package Type Update Change
ubuntu final major eoan -> jammy

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "before 2pm" (UTC).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review May 23, 2022 11:31
@viceice viceice requested a review from HonkingGoose May 23, 2022 11:41
HonkingGoose
HonkingGoose previously approved these changes May 24, 2022
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs.

@Gabriel-Ladzaretti
Copy link
Collaborator Author

Should i be doing anything else here ?

@viceice viceice enabled auto-merge (squash) May 30, 2022 07:29
@viceice viceice merged commit c92f052 into renovatebot:main May 31, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.70.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gabriel-Ladzaretti Gabriel-Ladzaretti deleted the 15475-automergeSchedule branch June 26, 2022 07:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a separate schedule for automerge
5 participants