-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): use repo url to get token #17179
Conversation
WDYT? |
httpMock | ||
.scope(githubApiHost, { | ||
reqheaders: { | ||
authorization: 'token abc', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
httpMock | ||
.scope('https://github.domain.com', { | ||
reqheaders: { | ||
authorization: 'token abc', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
Co-authored-by: Rhys Arkins <[email protected]>
let me test that first 🙋♂️ |
can I use |
should maybe also work for go |
works like a charm 🎉 Got 4 open PRs :
I need both in the config:
any other combination does not work (i'm OK with that)
|
would the API url for the hostrules be expected? can somebody give some advice where we should document this feature? |
If it's tightly related to Go then let's add it to https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/gomod/readme.md at least |
No, it's more relevant for datasources, so you can now override the token for a github repository for github-releases without interferring the app token |
Maybe somewhere in https://github.com/renovatebot/renovate/blob/main/docs/usage/getting-started/private-packages.md then |
ready for review |
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: HonkingGoose <[email protected]>
🎉 This PR is included in version 32.182.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: