fix(manager/composer): use intersects()
instead of matches()
to compare tool constraint
#34256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Within this pull request, I'm refactoring the
getComposerArguments()
function to make use of the newly addedintersects()
function to compare the tool version constraint.Context
While developing an unrelated feature, I realized that the
matches()
function that is being used to compare the tool version constraint in the Composer package manager returns unwanted results when the version is lower than the minimum required one, even if it's using the caret. For example, if the minimum required version is^2.6
and the tool constraint is^2.7
, the expected result should betrue
, butfalse
is returned instead. The following table shows some examples of what's happening:matches
^2.6
^2.7
false
matches
^2.8
^2.7
true
matches
2.6.0
^2.7
false
matches
2.7.0
^2.7
true
matches
2.8.0
^2.7
true
By switching to
intersects()
instead, the intersection of two ranges is handled correctly, as can be seen in the first row of the following table:intersects
^2.6
^2.7
true
intersects
^2.8
^2.7
true
intersects
2.6.0
^2.7
false
intersects
2.7.0
^2.7
true
intersects
2.8.0
^2.7
true
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: