Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate TgTypeParser to template and jsoncpp #315

Closed
wants to merge 19 commits into from
Closed

Migrate TgTypeParser to template and jsoncpp #315

wants to merge 19 commits into from

Conversation

Royna2544
Copy link
Contributor

@Royna2544 Royna2544 commented Sep 18, 2024 •
edited
Loading

  • The before implementation had some bugs, like createNewStickerSet failing due to invalid JSON. This converts the code to jsoncpp, removing manual string concatation.
  • Have to check if everything works out
  • Other misc improvements

@Royna2544
tgbot-cpp: Use explicit alias target for curl
4c804e9
@Royna2544
StringTools: Use boost replacements if possible
7497688
@Royna2544
TgTypeParser: Migrate to boost::ptree
ccd42be 
- The current method of manually appending string and commas are too lame and bug-prone, migrate to template-specialization based boost.PropertyTree for universal JSON fix
@Royna2544
TgTypeParser: Migrate to jsoncpp
d763910 
- Boost.PTree cannot support JSON fully, such as array of objects on root.
@Royna2544
Api: Turn off sendRequestDebug
1347693
@Royna2544
Dockerfile: Install jsoncpp
85e7e76
@Royna2544
Api: Be consistent on empty pointer
96ecf42 
- Nullptr is nullptr, do not make GenericReply::Ptr just for it
@Royna2544
Conditionally search pkgconfig for jsoncpp
30cd39f
@Royna2544
TgException: Use int for ErrorCode enum base
899d315
@Royna2544
BoostHttpClient: Throw exception with message
cfef920
@Royna2544
TgBotException: Add http 409 code
93a5234
@Royna2544 Royna2544 force-pushed the master branch 3 times, most recently from 44c6ca0 to 864a3aa Compare October 15, 2024 08:02
@Royna2544 Royna2544 marked this pull request as ready for review October 15, 2024 10:20
@Royna2544 Royna2544 marked this pull request as draft October 15, 2024 11:03
@Royna2544 Royna2544 closed this Oct 15, 2024
@Royna2544 Royna2544 reopened this Oct 15, 2024
@Royna2544 Royna2544 marked this pull request as ready for review October 15, 2024 11:23
@Royna2544 Royna2544 force-pushed the master branch 2 times, most recently from 8d72e9d to 1e43f02 Compare October 15, 2024 15:15
@Royna2544 Royna2544 closed this Oct 25, 2024
@reo7sp
Copy link
Owner

reo7sp commented Oct 28, 2024

Is it ready or draft?

@Royna2544
Copy link
Contributor Author

Royna2544 commented Oct 30, 2024 •
edited
Loading

Well, it's tested and confirmed working. If you want it merged, I will reopen
With these commit sets, it fixes some json problems like markup keyboards, botcommands on Windows, modernized codes for c++17 but changes some user land api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Royna2544 @reo7sp