Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create scanner for removing comments and continuations #2230

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Create scanner for removing comments and continuations #2230

wants to merge 11 commits into from

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Mar 27, 2025

  • When reading the requirements txt, handle line continuations and remove comments

@8W9aG
Create scanner for removing comments and continuations
477c5a9 
* When reading the requirements txt, handle line
continuations and remove comments
@8W9aG 8W9aG mentioned this pull request Mar 27, 2025
Open
aron
aron requested changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@aron aron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! In general the approach looks great. Before we merge I'd like to see tests for CRLF line endings and full line comments just to complete the coverage.

@8W9aG 8W9aG requested a review from aron March 27, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevillelyh nevillelyh Awaiting requested review from nevillelyh

@zsxkib zsxkib Awaiting requested review from zsxkib

@NikhilSinha1 NikhilSinha1 Awaiting requested review from NikhilSinha1

@aron aron Awaiting requested review from aron

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8W9aG @aron