Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiring up existing source maps of transpiled codes #692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Wiring up existing source maps of transpiled codes #692

wants to merge 2 commits into from

Commits on Jun 14, 2014

  1. Wiring up existing source maps of transpiled codes 

    When `generateSourceMaps` option is enabled, r.js now detects if the
module to be concatenated already declares a source map. It tries to
load the existing source map, and translates line numbers of all
mappings in that source map to those of the final output.

This fixes most of requirejs#470, and works well as long as `optimize` option is
set to `none`.  Some work still remains to pass a correct
`--in-source-map` option to UglifyJS when also uglifying.  Currently,
UglifyJS ignores r.js's carefully generated source map producing a bogus
one if `optimize` option is set to `uglify2`.

Used https://github.com/lydell/source-map-url (v0.2.0) for detecting
sourceMappingURL= comments from the code.
    @netj
    netj committed Jun 14, 2014
    Configuration menu
    Copy the full SHA
    3c3fbfa View commit details
    Browse the repository at this point in the history

  2. Ran ./copydist.js

    @netj
    netj committed Jun 14, 2014
    Configuration menu
    Copy the full SHA
    25489bc View commit details
    Browse the repository at this point in the history