files: fix upload of files with special characters in filename #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files: fix upload of files with special characters in filename sonar-ui#324
files: fix upload of files with special characters in filename ng-core#523
Co-Authored-by: Valeria Granata [email protected]
Why are you opening this PR?
#861
How to test / Notes for future debugging
a. Create a deposit with a file and publish it.
b. Create a document with a file (login as superuser)
Examples of filenames to test:
¿Es la unión mística un paradigma para la relación interpersonal? Una respuesta diferenciada en Edith Stein.pdf
L'âme humaine comme "intériorité".pdf
La portée anthropologique du symbole du château chez sainte Thérèse d'Avila.pdf
Le symbole du château. Une proposition d’interprétation relationnelle.pdf
Betschart - 2017 - La portée anthropologique du symbole du château ch.pdf
&%/? éàèê/üäö$£/(){}*"'`+-!$.pdf
Logged in as superuser in the Administration section:
An example of what could happen is in the screenshot below where the file “Le symbole du château. Une proposition d’interprétation relationnelle.pdf” disappeared from the list and the links for this file do not work any longer.
In this specific case the problem is the right single quotation mark in “d’interprétation” that during the actions above is sometimes encoded into apostrophe.
Sometimes after one of the action above several fields in the files metadata disappear (type, label, links, order, restriction, thumbnail) and the files are no more visible. In the example below, the file "La portée anthropologig…e Thérèse d'Avila.pdf" is still visible but the others have disappeared.
Code review check list