Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: String #27

Merged
merged 19 commits into from
Mar 2, 2023
Merged

Documentation: String #27

merged 19 commits into from
Mar 2, 2023

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Feb 12, 2023 •
edited
Loading

aspeddro
aspeddro commented Feb 12, 2023
View reviewed changes
zth
zth reviewed Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few small comments/suggestions. Also, could we ensure that nothing is prefixed with Belt in here, so we refer to the right modules? I saw that some example code had references to Belt.Int for example, when it should be just Int.

@zth zth mentioned this pull request Feb 15, 2023
Open
49 tasks
zth
zth reviewed Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 2 small comments, and then docstrings for the 3 missing things that you've already noted, and then I believe we're good to go.

@zth
Copy link
Collaborator

zth commented Feb 27, 2023

@aspeddro is this ready to go?

@aspeddro aspeddro marked this pull request as ready for review March 1, 2023 13:45
@aspeddro
Copy link
Contributor Author

aspeddro commented Mar 1, 2023

@aspeddro is this ready to go?

yes

@aspeddro aspeddro mentioned this pull request Mar 2, 2023
Open
@zth zth merged commit a976a8c into rescript-lang:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspeddro @zth