-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shift(<<
, >>
, >>>
) operator
#7183
base: master
Are you sure you want to change the base?
Conversation
@@ -301,7 +301,7 @@ let operator_precedence operator = | |||
| "||" -> 2 | |||
| "&&" -> 3 | |||
| "=" | "==" | "<" | ">" | "!=" | "<>" | "!==" | "<=" | ">=" | "|>" -> 4 | |||
| "+" | "+." | "-" | "-." | "^" -> 5 | |||
| "+" | "+." | "-" | "-." | "^" | "<<" -> 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to dedicate precedence for shift operators, according to JS' one
Hi @gwansikk! Would be great to get this PR merged - do you have time to pick up work on it again? |
of course! I had been missing it due to personal matters. I will try to work on it as soon as possible. |
This now has conflicts because I removed |
Got it! I’ll take care of it and aim to wrap up the task within this week. Apologies for the delay(this PR work). |
related: #7171
ref: