Fix issue in functors with more than one argument (which are curried): emit nested function always. #7273
+131
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
commented
Feb 2, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: d47e432 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.3674560733333332 ms |
1.2123143266666667 ms |
1.13 |
Parse Napkinscript.res - time/run |
42.69906948 ms |
39.28006235333333 ms |
1.09 |
Parse HeroGraphic.res - time/run |
5.75563878 ms |
5.13472718 ms |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
5 tasks
…port Simplify functor translation and remove merged functors support - Remove Conflicting_inline_attributes error type and related checks - Simplify apply_coercion_result to handle single parameters instead of lists - Replace recursive merge_functors with get_functor_params for single-level handling - Streamline compile_functor to process individual functor parameters directly - Remove obsolete code for handling merged functors and inline attribute merging These changes simplify the functor translation logic by eliminating support for merged functors and associated complex coercion handling, focusing on single-level functor processing instead.
cristianoc
force-pushed
the
functor-one-arg
branch
from
01662c1 to
d47e432
Compare
|
I think we can go ahead with this, unless there's some functor-heavy repository (with multiple args) to test this on. |
cristianoc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7245