Complete tagged template application #7278
Merged
+156
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
reviewed
Feb 5, 2025
analysis/src/CompletionFrontEnd.ml
Outdated
Comment on lines
1155
to
1156
| (* This is likely to be an exprhole *) | ||
| | _ -> "" |
There was a problem hiding this comment.
I think we could add the explicit match (or an if branch using the utils we have for expr holes) just to make the code a bit clearer in what we care about in the AST. What do you think?
There was a problem hiding this comment.
I'm not against having an explicit match, but I don't know what else to return when it is anything else, that is why I went with | _ -> "".
There was a problem hiding this comment.
Yeah that'd remain, you'd just also add the explicit match for clarity, even though it's redundant.
There was a problem hiding this comment.
I split them after al.
Seems most clear to me.
zth
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
in https://github.com/zth/rescript-bun wasn't completing.
In this PR I'm adding the support for dot completion to be picked up from a frontend/syntax point of view.
This doesn't fully solve my problem but is useful nonetheless.