WIP: Stdlib namespace for Core modules #7285
Conversation
cknitt
force-pushed
the
stdlib-namespace
branch
3 times, most recently
from
af47499 to
5c0a664
Compare
| "insertText": "Some(${1:_})", | ||
| "insertTextFormat": 2 | ||
| }, { | ||
| "label": "Some(date)", | ||
| "label": "Some(stdlib_Date)", |
There was a problem hiding this comment.
@zth Weird that this starts with a lower case letter here.
There was a problem hiding this comment.
Well, it's an identifier so it's not weird per se. But, we should probably filter out the stdlib part.
| @@ -35,76 +35,76 @@ Package opens Pervasives.JsxModules.place holder | |||
| ContextPath Type[withDate] | |||
| Path withDate | |||
| [{ | |||
| "label": "Js.Date.makeWithYMD()", | |||
| "label": "Stdlib_Date.makeWithYMD()", | |||
There was a problem hiding this comment.
@zth Here we need to do something to get Date instead of Stdlib_Date.
There was a problem hiding this comment.
Yup! We need to filter out Stdlib_ whenever it appears. I think we can make this a separate issue that we can worry about in a separate PR after this one is merged. Do you agree?
There was a problem hiding this comment.
@zth I don't know, there are other issues with analysis now, many completions have disappeared. Would be good to get this fixed as part of this PR I think.
Maybe you can help me there, I'll let you know when I have finished everything from my side.
cknitt
force-pushed
the
stdlib-namespace
branch
from
5c0a664 to
91818bb
Compare
| @@ -21,6 +21,8 @@ export const someFunWithNullUndefinedArg: unknown = someFunWithNullUndefinedArgT | |||
|
|
|||
| const CoreJS = require('./Core.res.js'); | |||
|
|
|||
| import type {Date_t as Stdlib_Date_t} from './Stdlib.gen'; | |||
There was a problem hiding this comment.
@cristianoc How can I avoid this?
cknitt
force-pushed
the
stdlib-namespace
branch
4 times, most recently
from
42038a5 to
93beba5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: dcd26b9 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.3641321999999998 ms |
1.2123143266666667 ms |
1.13 |
Parse Napkinscript.res - time/run |
42.868526106666664 ms |
39.28006235333333 ms |
1.09 |
Parse HeroGraphic.res - time/run |
5.7648673 ms |
5.13472718 ms |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt
force-pushed
the
stdlib-namespace
branch
2 times, most recently
from
dab5123 to
8ed70db
Compare
cknitt
force-pushed
the
stdlib-namespace
branch
2 times, most recently
from
5a4c52c to
33dd8c6
Compare
cknitt
force-pushed
the
stdlib-namespace
branch
5 times, most recently
from
45ef852 to
183e888
Compare
cknitt
force-pushed
the
stdlib-namespace
branch
from
183e888 to
dcd26b9
Compare
This is to avoid name clashes with user modules as observed in #7126 (comment).