#1446: dispatch tests cases into Maven modules #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboileau
commented
Feb 2, 2025
| @@ -52,16 +52,13 @@ public final class ChallengeResponse extends ChallengeMessage { | |||
| private volatile String secretAlgorithm; | |||
|
|
|||
| /** The server nonce count. */ | |||
| private volatile int serverNounceCount; | |||
| private volatile int serverNonceCount; | |||
There was a problem hiding this comment.
the word nonce was mispelled. I've deprecated the accessors and add new ones.
thboileau
commented
Feb 2, 2025
| @@ -0,0 +1,36 @@ | |||
| /** | |||
There was a problem hiding this comment.
I forgot to add the tests for the GWT edition
thboileau
commented
Feb 2, 2025
| @@ -1,21 +1,21 @@ | |||
| /** | |||
| * Copyright 2005-2024 Qlik | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
we'll have to take care of code formatting...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim
Mavenify the projects by dispatching the existing test cases into the convenient module.
Check-list
DO NOT REVIEW